Remove unused pSpatialLayer variable in DetermineTemporalSettings #3761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which break on Mac CI settings due to the variables being unused
|
looks like the Mac defaults changed? WDYT about adding to |
|
mac build failed, test/decoder/DecUT_DecExt.cpp:143:11: error: variable 'iSliceIndex' set but not used [-Werror,-Wunused-but-set-variable] @fippo |
|
Thank you, there was more after that even (and oddly adding those compiler defines to the linux build did not help). |
bgilbert
added a commit
to bgilbert/openh264
that referenced
this pull request
Nov 10, 2024
Avoids Meson warning at configure time:
meson.build:49: WARNING: Consider using the built-in werror option instead of using "-Werror".
Fixes: de02617 ("Remove unused pSpatialLayer variable in DetermineTemporalSettings (cisco#3761)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which breaks on Mac CI settings due to the variable being unused
Fixes the build issue from #3752, as a separate commit for papertrail reasons.